Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ilike operator #124

Merged
merged 1 commit into from
Oct 25, 2017
Merged

add ilike operator #124

merged 1 commit into from
Oct 25, 2017

Conversation

sylvainlap
Copy link
Contributor

Allows to support the postgres ILIKE operator.

@daffl
Copy link
Member

daffl commented Oct 20, 2017

Thank you! Is there any other operators you think we should map? New operators also need to be added to the documentation at https://docs.feathersjs.com/api/databases/knexjs.html#querying.

@sylvainlap
Copy link
Contributor Author

the documentation has been updated here: feathersjs-ecosystem/docs#886

@daffl
Copy link
Member

daffl commented Oct 24, 2017

Sweet, thank you. A test would be nice as well. Probably just a copy of https://github.com/feathersjs-ecosystem/feathers-knex/blob/master/test/index.test.js#L106 querying for %char%

@sylvainlap
Copy link
Contributor Author

I cannot add a test, because your tests run sqlite, and ilike is a psql only operator.

@daffl
Copy link
Member

daffl commented Oct 25, 2017

Makes sense. I created a follow-up issue in #128 to run CI against other dbs as well so we can revisit this then.

@daffl daffl merged commit 6b1f76c into feathersjs-ecosystem:master Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants